Opened on 07/22/2017 at 06:33:05 PM
Closed on 09/13/2017 at 01:18:51 PM
#5447 closed change (fixed)
Add missing essential meta data to adblockplus.org
| Reported by: | juliandoucette | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | ire, wspee, saroyanm, lisabielik, jeen | Blocked By: | #5343 |
| Blocking: | #146, #1198, #1274 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Background
I will add [standard, search, social, article, etc] meta data to all websites using shared includes in website-defaults soon. However, because our websites are being actively searched and shared, I would like to add support for the following meta fields to improve our search/share results immediately.
What to change
Ensure the following fields are supported
- title (required)
- og:title (generated by title)
- description (optional)
- og:description (optional, generated by description)
- canonical link and og:url (generated by get_canonical_link
- og:locale and og:locale:alternate (generated by to_og_locale from #5329)
Attachments (0)
Change History (23)
comment:1 Changed on 07/22/2017 at 06:35:38 PM by juliandoucette
- Type changed from defect to change
comment:2 Changed on 07/22/2017 at 06:49:41 PM by juliandoucette
- Blocking 146 added
comment:3 Changed on 07/22/2017 at 07:43:57 PM by juliandoucette
- Blocking 1274 added
comment:5 Changed on 07/22/2017 at 07:52:10 PM by juliandoucette
- Blocked By 5343 added
- Description modified (diff)
comment:7 Changed on 07/22/2017 at 07:57:25 PM by juliandoucette
- Description modified (diff)
- Ready unset
comment:8 Changed on 08/08/2017 at 09:44:06 PM by juliandoucette
- Owner set to juliandoucette
comment:9 Changed on 08/08/2017 at 09:46:46 PM by juliandoucette
- Owner juliandoucette deleted
comment:10 Changed on 08/09/2017 at 09:51:06 PM by juliandoucette
- Description modified (diff)
- Owner set to juliandoucette
- Ready set
comment:11 Changed on 08/09/2017 at 09:53:12 PM by juliandoucette
- Description modified (diff)
comment:12 Changed on 08/09/2017 at 09:55:35 PM by juliandoucette
- Description modified (diff)
comment:13 Changed on 08/09/2017 at 10:14:02 PM by juliandoucette
- Description modified (diff)
comment:14 Changed on 08/09/2017 at 10:22:53 PM by juliandoucette
- Description modified (diff)
comment:15 Changed on 08/09/2017 at 10:51:46 PM by juliandoucette
- Blocking 1198 added
comment:16 Changed on 08/10/2017 at 09:21:31 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:17 Changed on 08/17/2017 at 04:25:38 PM by abpbot
comment:18 Changed on 08/17/2017 at 05:06:33 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
comment:19 Changed on 08/22/2017 at 01:12:25 PM by abpbot
A commit referencing this issue has landed:
Issue 5447 - Added canonical link to standard meta include
comment:20 Changed on 09/01/2017 at 10:43:17 AM by juliandoucette
- Resolution fixed deleted
- Status changed from closed to reopened
This change was backed-out because the page property is not reliable on blog pages.
comment:21 Changed on 09/13/2017 at 12:31:00 PM by abpbot
A commit referencing this issue has landed:
Issue 5447 - Added missing essential meta data
comment:22 Changed on 09/13/2017 at 01:17:36 PM by abpbot
A commit referencing this issue has landed:
Issue 5447 - Fixed 'locales' vs 'available_locales' mixup
comment:23 Changed on 09/13/2017 at 01:18:51 PM by juliandoucette
- Resolution set to fixed
- Status changed from reopened to closed
A commit referencing this issue has landed:
Issue 5447 - Add missing essential meta data to adblockplus.org