Opened on 07/28/2017 at 03:25:59 PM

Closed on 09/22/2017 at 01:32:53 PM

#5456 closed change (fixed)

Add support to specify urlFilters in the notification repository

Reported by:	wspee	Assignee:	wspee
Priority:	Unknown	Milestone:
Module:	Sitescripts	Keywords:
Cc:	kvas	Blocked By:
Blocking:		Platform:	Unknown / Cross platform
Ready:	no	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29500676/

Description

Background

In #4827/#4762 we added support for relentless notifications. They are supposed to be used for specific website but currently it's not possible to specify urlFilters attribute via the noticifation repository.

What to change

Add support to specify the urlFilters attribute of relentless notifications via the noticifation repository by specifying a space seperated list of domains:

Notification repository format:

inactive = no

severity = relentless
title.en-US = Test
message.en-US = Test
urls = foo.com bar.com

Resulting notification.json:

{
  "notifications": [
    {
      "id": "1",
      "message": {
        "en-US": "Test"
      },
      "severity": "relentless",
      "title": {
        "en-US": "Test"
      },
      "urlFilters": [
        "FOO.COM^$document",
        "BAR.COM^$document"
      ]
    }
  ],
  "version": "201707281520"
}

Change History (4)

comment:1 Changed on 07/28/2017 at 03:32:43 PM by wspee

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:2 Changed on 07/31/2017 at 08:34:29 AM by wspee

Owner set to wspee

comment:3 Changed on 09/22/2017 at 10:29:44 AM by abpbot

A commit referencing this issue has landed:
Issue 5456 - Add support to specify urlFilters in the notification repository

comment:4 Changed on 09/22/2017 at 01:32:53 PM by wspee

Resolution set to fixed
Status changed from reviewing to closed

Summary:

Description:

You may use WikiFormatting here.

Type:

Priority:

Milestone:

Module:

Keywords:

Cc:

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Verified working:

Review URL(s):

Context Navigation

#5456 closed change (fixed)

Add support to specify urlFilters in the notification repository

Description

Background

What to change

Attachments (0)

Change History (4)

comment:1 Changed on 07/28/2017 at 03:32:43 PM by wspee

comment:2 Changed on 07/31/2017 at 08:34:29 AM by wspee

comment:3 Changed on 09/22/2017 at 10:29:44 AM by abpbot

comment:4 Changed on 09/22/2017 at 01:32:53 PM by wspee

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. == Background == In #4827/#4762 we added support for relentless notifications. They are supposed to be used for specific website but currently it's not possible to specify urlFilters attribute via the [https://hg.adblockplus.org/notifications/ noticifation repository]. == What to change == Add support to specify the urlFilters attribute of relentless notifications via the [https://hg.adblockplus.org/notifications/ noticifation repository] by specifying a space seperated list of domains: Notification repository format: {{{ inactive = no severity = relentless title.en-US = Test message.en-US = Test urls = foo.com bar.com }}} Resulting notification.json: {{{ { "notifications": [ { "id": "1", "message": { "en-US": "Test" }, "severity": "relentless", "title": { "en-US": "Test" }, "urlFilters": [ "FOO.COM^$document", "BAR.COM^$document" ] } ], "version": "201707281520" } }}}
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29500676/