Opened on 07/31/2017 at 08:43:27 AM

Closed on 08/25/2017 at 09:19:21 AM

Last modified on 09/25/2017 at 01:18:18 PM

#5460 closed change (fixed)

Add support to show a notification based on the locale of the user

Reported by: wspee Assignee: wspee
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev, sebastian Blocked By:
Blocking: #5458 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29501607/

Description (last modified by wspee)

Background

For our upcoming cross promotion campaign we want to be able to show notifications to users that use a certain locale.

What to change

Add support to show a notification only if the user uses a certain locale, as specified in #5458.

Attachments (0)

Change History (9)

comment:1 Changed on 07/31/2017 at 12:17:35 PM by wspee

  • Description modified (diff)

comment:2 Changed on 07/31/2017 at 03:17:03 PM by wspee

  • Cc snoack trev added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/31/2017 at 03:30:44 PM by wspee

  • Blocking 5458 added

comment:4 Changed on 08/01/2017 at 03:14:57 PM by sebastian

  • Cc sebastian added; snoack removed

comment:5 Changed on 08/21/2017 at 04:08:46 PM by wspee

  • Review URL(s) modified (diff)

comment:6 Changed on 08/25/2017 at 09:10:27 AM by abpbot

comment:7 Changed on 08/25/2017 at 09:19:21 AM by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 08/29/2017 at 06:47:17 AM by trev

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed on 09/25/2017 at 01:18:18 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This works in Chrome. Unable to test in Opera at the moment due to #5759.

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from wspee.
 
Note: See TracTickets for help on using tickets.