Opened on 08/08/2017 at 11:10:45 PM

Closed on 08/31/2017 at 10:33:42 AM

#5479 closed defect (fixed)

"dk" locale code should be "da"

Reported by: juliandoucette Assignee:
Priority: Unknown Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee, saroyanm, kvas, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

How to reproduce

Observed behaviour

  • We have been sending the wrong locale code?
  • Crowdin has been accepting the wrong locale code?
    • Our Danish translation strings in Crodwin are up-to-date

Expected behaviour

  • Send the correct/up-to-date Danish locale code to Crowdin

Attachments (0)

Change History (4)

comment:1 Changed on 08/08/2017 at 11:11:06 PM by juliandoucette

The same applies to web.adblockbrowser.org.

comment:2 Changed on 08/08/2017 at 11:12:33 PM by juliandoucette

@kvas, @jsonesen, @saroyanm

It wouldn't hurt to have a second set of eyes on this. It seems strange to me that we have been sending the wrong code and Crowdin has been processing it properly.

comment:3 Changed on 08/30/2017 at 03:26:13 PM by Shikitita

By the looks of it, Crowdin's locale for Danish is [da]. Other websites, however, use different combinations as well such as [da_DK] or [da-DK].

comment:4 Changed on 08/31/2017 at 10:33:42 AM by juliandoucette

  • Resolution set to fixed
  • Status changed from new to closed

Resolved by ​https://hg.adblockplus.org/web.adblockplus.org/rev/ff42500db621

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.