Opened on 08/11/2017 at 07:35:37 AM
Closed on 08/14/2017 at 02:50:18 PM
#5496 closed defect (fixed)
Update the browser-version request-url for Chrome
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | wspee, sebastian, saroyanm, juliandoucette, ire, kvas, jsonesen, tlucas | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
The https://adblockplus.org/en/requirements -site is out of sync (apparently again) while using the Google Update Services. The chromium-maintainers suggest using their omahaproxy instead (see https://www.chromium.org/administrators/frequently-asked-questions, search for "other platforms")
What to change
Change the current machinery for getting the current chrome-versions in get_browser_versions.py to use the url
https://omahaproxy.appspot.com/all.json?os=win
instead of the currently prepared request to https://tools.google.com/service/update2 and adhere to the expected/established output.
Attachments (0)
Change History (8)
comment:1 Changed on 08/11/2017 at 12:51:12 PM by sebastian
- Cc saroyanm juliandoucette added
comment:2 Changed on 08/11/2017 at 03:43:37 PM by sebastian
- Type changed from change to defect
comment:3 Changed on 08/11/2017 at 08:10:23 PM by juliandoucette
- Cc ire kvas jsonesen tlucas added
- Priority changed from Unknown to P2
- Ready set
~P2 because this can cause the generation script to fail.
[@kvas, @jsonesen, @tlucas] feel free to address this issue yourselves (despite it being websites module) (especially if the result is less error prone :p)
comment:4 Changed on 08/14/2017 at 08:01:52 AM by tlucas
- Owner set to tlucas
comment:5 Changed on 08/14/2017 at 08:02:20 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 08/14/2017 at 02:46:53 PM by abpbot
A commit referencing this issue has landed:
Issue 5496 - Use omahaproxy to get chrome-versions
comment:8 Changed on 08/14/2017 at 02:50:18 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
As discussed on IRC, I agree to the solution suggested here. However, setting the Priority and Ready state of this issue is up to the Websites module owner/peer.