Opened on 08/11/2017 at 10:44:48 AM

Closed on 02/08/2018 at 05:00:55 PM

Last modified on 02/19/2018 at 02:10:19 PM

#5504 closed change (fixed)

Update comment in accordance with the code

Reported by: sergz Assignee: Yael
Priority: Unknown Milestone:
Module: Core Keywords: goodfirstbug
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://github.com/adblockplus/adblockpluscore/pull/1

Description

Background

The line
​https://github.com/adblockplus/adblockpluscore/blob/8518e34fce4264d7c74a187f424c577292a3ce39/lib/filterStorage.js#L622 is outdated because currently the property is index, not {nsIFile} file.

Attachments (0)

Change History (7)

comment:1 Changed on 12/21/2017 at 11:26:28 AM by fhd

  • Cc trev removed

comment:2 Changed on 01/04/2018 at 01:27:06 PM by sergz

  • Keywords goodfirstbug added

comment:3 Changed on 02/07/2018 at 12:55:25 PM by sergz

  • Cc kzar added

comment:4 Changed on 02/08/2018 at 04:58:57 PM by abpbot

A commit referencing this issue has landed:
​Issue 5504 - fix description of FileInfo index property

comment:5 Changed on 02/08/2018 at 05:00:55 PM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed on 02/08/2018 at 05:01:25 PM by sergz

  • Review URL(s) modified (diff)

comment:7 Changed on 02/19/2018 at 02:10:19 PM by kzar

  • Owner set to Yael

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Yael.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.