Opened on 08/11/2017 at 02:47:07 PM
Closed on 09/05/2017 at 01:57:13 PM
#5508 closed change (fixed)
Implement virtual file system in tests.
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | #5475 | |
| Blocking: | #5183 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
After #5475 we can provide with a very simple implementation of a virtual file system, therefore get rid of using of a default file system in tests.
What to change
Implement IFileSystem which stores files in the memory and use it everywhere in tests instead of default implementation of file system.
Attachments (0)
Change History (4)
comment:1 Changed on 09/04/2017 at 09:10:42 AM by sergz
- Blocking 5183 added
- Owner set to sergz
- Priority changed from P5 to P2
comment:2 Changed on 09/04/2017 at 09:51:00 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/05/2017 at 01:56:41 PM by abpbot
A commit referencing this issue has landed:
Issue 5508 - implement InMemoryFS for tests
comment:4 Changed on 09/05/2017 at 01:57:13 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
The changes related to this issue simplify the process of switching from std::shared_ptr to std::unique_ptr of IFileSystem held by Platform.