#5516 closed change (fixed)

Bundle the browser tests and dependencies using webpack, adding module support

Reported by:	kzar	Assignee:	kzar
Priority:	P3	Milestone:
Module:	Core	Keywords:
Cc:	trev, fhd, hfiguiere	Blocked By:
Blocking:	#5079	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://codereview.adblockplus.org/29517687/

Since we're going to start using modules for the content scripts we need to add support for modules to the browser tests in adblockpluscore too.

Modify runBootstrap in chromiumium_process.js to bundle together all the browser test files and any module dependencies using webpack before compiling and running them inside the Chromium process.
Have test/browser/_bootstrap.js export the init function, which the test runner can call with the same arguments as before. That way only even though all the browser tests will always be included by webpack, only the ones specified will be run.
Remove the loadScript and similar logic from test/browser/_bootstrap.js.
Remove the loadScript calls from test/browser/elemHideEmulation.js, instead calling require to include the elemHideEmulation module.

This converts elemHideEmulation into a module, so it needs to be ensured that it can be loaded as such.

It should be verified that element hiding emulation functionality still works.

Done. Element hiding functionality still works (except for non-regression #5773).

ABP 1.13.3.1838
Chrome 52 / 61 / Windows 7
Opera 40 / 47 / Windows 7

Summary:
Description:	You may use WikiFormatting here. === Background === Since we're going to start using modules for the content scripts we need to add support for modules to the browser tests in adblockpluscore too. === What to change === - Modify `runBootstrap` in `chromiumium_process.js` to bundle together all the browser test files and any module dependencies using [https://webpack.js.org/ webpack] before compiling and running them inside the Chromium process. - Have `test/browser/_bootstrap.js` export the init function, which the test runner can call with the same arguments as before. That way only even though all the browser tests will always be included by webpack, only the ones specified will be run. - Remove the `loadScript` and similar logic from `test/browser/_bootstrap.js`. - Remove the `loadScript` calls from `test/browser/elemHideEmulation.js`, instead calling require to include the elemHideEmulation module. === Integration notes === This converts elemHideEmulation into a module, so it needs to be ensured that it can be loaded as such. === Hints for testers === It should be verified that element hiding emulation functionality still works.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29517687/