Opened on 08/22/2017 at 11:39:49 AM

Closed on 08/24/2017 at 10:47:32 AM

Last modified on 09/11/2017 at 12:43:52 PM

#5554 closed change (fixed)

[webextensions] Adjust data to account for UI limitations

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29526555/

Description

Background

We are going to migration Firefox users to our Web Extensions build soon. They will have some data that the "new" UI cannot handle.

What to change

  • Any disabled subscription filters should be enabled.
  • Any disabled custom filters should be replaced by ! <filter> comment.
  • Filter hit counts and last hit values should be reset.
  • Existing automatic backups (meaning any pseudo-files other than patterns.ini) should be removed.

Attachments (0)

Change History (5)

comment:1 Changed on 08/22/2017 at 11:52:35 AM by sebastian

  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed on 08/24/2017 at 09:10:31 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/24/2017 at 10:47:05 AM by abpbot

A commit referencing this issue has landed:
Issue 5554 - [webextensions Adjust data to account for UI limitations]

comment:4 Changed on 08/24/2017 at 10:47:32 AM by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 09/11/2017 at 12:43:52 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Disabled filters in subscriptions are enabled. Disabled custom filters are replaced with comment versions. Filter counts are reset and backups are removed. Other settings like Acceptable Ads, subscriptions, subscription state are also migrated as expected.

ABP 2.9.1 -> ABP 2.99.0.1838beta
Firefox 55 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.