Opened on 08/22/2017 at 02:36:02 PM
Closed on 09/27/2017 at 07:33:48 AM
#5556 closed change (fixed)
Update to use libadblockplus revision hg:566f64c8a2a8
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | asmirnov | Blocked By: | #5569, #5617 |
| Blocking: | #5643 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29523679/ |
||
Description (last modified by sergz)
Background
adblockpluscore has been updated in libadblockplus, there are some changes affecting the size of memory usage, therefore it would be good to update libadblockplus in libadblockplus-android as soon as possible at least to measure the current memory usage. For the full list of changes in adblockpluscore introduced into libadblockplus please see #5475.
| e530495163f2 | Noissue - remove additional empty line | Sergei Zabolotskikh |
| 2cb6e4491fc2 | Noissue - fix overlooked comment for Platform::GetLogSystem | Sergei Zabolotskikh |
| 233aac8400de | Noissue - Updated copyright year | Wladimir Palant |
| 7f3818ccb4d1 | Noissue - fix the value of gyp -Gandroid_ndk_version parameter in accordance to the used Android NDK | Sergei Zabolotskikh |
| 8b825a798649 | Noissue - fix running of native tests on android | Sergei Zabolotskikh |
| cd1d9588cc56 | Noissue - Fix a constructor order warning | Hubert Figuière |
| 937936b9df5a | Noissue - set default values for platform interfaces to nullptr | Sergei Zabolotskikh |
| e59e76660ee9 | Noissue - remove unnecessary sleeps in FileSystemJsObject tests | Sergei Zabolotskikh |
| ffd0d8ba35fe | Noissue - code style: use override for overridden methods of MockFileSystem | Sergei Zabolotskikh |
| b16c48c68880 | Noissue - remove unnecessary including of v8.h | Sergei Zabolotskikh |
What to change
Prepare and update libadblockplus-binaries dependency to libadblockplus hg:566f64c8a2a8 revision as well as adapt the code.
Attachments (0)
Change History (25)
comment:3 Changed on 08/24/2017 at 06:21:29 PM by sergz
- Blocked By 5569 added
- Description modified (diff)
comment:4 Changed on 08/25/2017 at 05:47:21 AM by abpbot
comment:5 Changed on 08/25/2017 at 05:52:12 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c
comment:7 Changed on 08/29/2017 at 10:30:08 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c
comment:8 Changed on 08/29/2017 at 10:35:24 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c
comment:9 Changed on 08/29/2017 at 10:45:48 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c
comment:10 Changed on 08/29/2017 at 10:52:59 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c
comment:11 Changed on 09/01/2017 at 09:43:18 AM by sergz
- Review URL(s) modified (diff)
comment:12 Changed on 09/04/2017 at 11:09:31 AM by sergz
- Blocked By 5617 added
comment:13 Changed on 09/05/2017 at 12:24:44 PM by sergz
- Review URL(s) modified (diff)
comment:14 Changed on 09/05/2017 at 12:57:41 PM by sergz
- Review URL(s) modified (diff)
comment:15 Changed on 09/05/2017 at 01:27:19 PM by sergz
- Review URL(s) modified (diff)
comment:16 Changed on 09/05/2017 at 06:02:39 PM by sergz
- Description modified (diff)
- Summary changed from Update to use libadblockplus revision hg:36e9993fa36c to Update to use libadblockplus revision hg:566f64c8a2a8
New changes simplifying the update had been landed in libadblockplus, therefore the issue description has been updated.
comment:17 Changed on 09/06/2017 at 08:15:59 AM by asmirnov
- Review URL(s) modified (diff)
comment:18 Changed on 09/07/2017 at 11:34:36 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:19 Changed on 09/08/2017 at 09:23:54 AM by sergz
- Blocking 5643 added
comment:20 Changed on 09/08/2017 at 09:39:24 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:21 Changed on 09/08/2017 at 09:53:24 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:22 Changed on 09/08/2017 at 10:26:22 AM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:23 Changed on 09/08/2017 at 07:50:54 PM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:24 Changed on 09/11/2017 at 12:31:34 PM by abpbot
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8
comment:25 Changed on 09/27/2017 at 07:33:48 AM by sergz
- Resolution set to fixed
- Status changed from new to closed
A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c