#5558 closed change (fixed)

Make notifications not ignore unknown targets

Reported by:	wspee	Assignee:
Priority:	P3	Milestone:
Module:	Core	Keywords:
Cc:	trev	Blocked By:
Blocking:		Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://codereview.adblockplus.org/29501607/

Currently the notification system will ignore unknown targets:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf

This means that whenever we add a new target we have to be very careful to also check for the version the target was added, e.g.:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf extensionVersion>=VERSION_THE_FEATURE_WAS_ADDED

It would be safer if the extension would not show notifications with unknown targets.

No longer ignore unknown targets, instead don't show a notification with an unknown target.

Done. This works in Chrome. Unable to test in Opera at the moment due to #5759.

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 7

Summary:
Description:	You may use WikiFormatting here. === Background === Currently the notification system will ignore unknown targets: {{{ title.en-US = Test message.en-US = Test severity = normal target = newFeature=111111elf }}} This means that whenever we add a new target we have to be very careful to also check for the version the target was added, e.g.: {{{ title.en-US = Test message.en-US = Test severity = normal target = newFeature=111111elf extensionVersion>=VERSION_THE_FEATURE_WAS_ADDED }}} It would be safer if the extension would not show notifications with unknown targets. === What to change === No longer ignore unknown targets, instead don't show a notification with an unknown target.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29501607/