Opened on 08/29/2017 at 11:41:21 AM
Closed on 08/31/2017 at 06:44:18 PM
Last modified on 09/11/2017 at 06:51:55 AM
#5588 closed defect (fixed)
[webextension] Icon badge not reset when navigating to a new page
| Reported by: | trev | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.13.4-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | kzar, mjethani, sebastian | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29530598/ |
||
Description (last modified by trev)
Environment
Firefox 55, Adblock Plus 2.99.0.1822
How to reproduce
- Go to https://www.heise.de/
- Go to http://example.com/
- Click Adblock Plus icon.
Observed behaviour
The icon badge is still showing a number of ads blocked while the popup says "0 on this page" - example.com doesn't have any ads to be blocked.
Expected behaviour
The icon badge is reset when navigating to example.com and is no longer visible.
Background
Navigation doesn't clear tab badge in Firefox: https://bugzil.la/1395074
Attachments (0)
Change History (14)
comment:1 Changed on 08/29/2017 at 11:42:30 AM by trev
- Component changed from User-Interface to Platform
comment:2 Changed on 08/29/2017 at 11:49:05 AM by kzar
- Cc kzar mjethani sebastian added
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 08/29/2017 at 08:40:02 PM by mjethani
- Owner set to mjethani
comment:4 Changed on 08/29/2017 at 08:50:32 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 08/30/2017 at 05:01:06 PM by abpbot
comment:7 Changed on 08/30/2017 at 05:01:31 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 08/31/2017 at 05:44:22 PM by mjethani
- Resolution fixed deleted
- Status changed from closed to reopened
Unfortunately this breaks Chrome, reopening.
comment:9 Changed on 08/31/2017 at 05:56:20 PM by mjethani
- Review URL(s) modified (diff)
Chrome dispatches the loading event after the page has already started getting
hits. If the stats module clears the text at this time, it can remain cleared if
all the hits have already been counted.
This behavior can be observed by opening a new tab and quickly typing the URL
and hitting Enter. If the page has only one hit, it'll be cleared from the
badge.
comment:10 Changed on 08/31/2017 at 05:56:30 PM by mjethani
- Status changed from reopened to reviewing
comment:11 Changed on 08/31/2017 at 06:43:34 PM by abpbot
A commit referencing this issue has landed:
Issue 5588 - Clear badge text only if zero hits
comment:12 Changed on 08/31/2017 at 06:44:18 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 09/05/2017 at 10:18:35 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:14 Changed on 09/11/2017 at 06:51:55 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Counters are reset as expected.
ABP 1.13.13.1838
Chrome 49 / 60 / Windows 7
Opera 36 / 46 / Windows 7
ABP 2.99.0.1838beta
Firefox 55 / Windows 7
A commit referencing this issue has landed:
Issue 5588 - Explicitly clear badge text on tab update