Opened on 08/31/2017 at 08:30:09 AM

Closed on 08/31/2017 at 08:34:58 AM

#5602 closed change (duplicate)

Use existing v8::Isolate instance

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We use V8 JS engine to run JS code, see JsEngine class. At the it creates a new v8::Isolate instance (see ScopedV8Isolate class ctor). However if using libadblockplus embedded we should accept existing v8::Isolate instance to be used. For example, it's required to embed it to Qualcomm chromium fork if using Chromium v8. Libadblockplus-android will pass existing reference if having it.

What to change

Accept v8::Isolate instance pointer and use it or create a new at the moment.

Attachments (0)

Change History (2)

comment:1 Changed on 08/31/2017 at 08:34:35 AM by asmirnov

Duplicates #5570

comment:2 Changed on 08/31/2017 at 08:34:58 AM by asmirnov

  • Resolution set to duplicate
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.