Opened on 09/06/2017 at 09:46:19 PM

Closed on 01/09/2018 at 08:01:41 AM

#5635 closed change (fixed)

Implement website-default navbar component

Reported by: juliandoucette Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: wspee, ire Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29587584/

Description (last modified by juliandoucette)

Background

Based on the requirements for the help center and the new adblockplus.org...

What to change

Fork the help-center header .navbar into a website-defaults navbar component that is compatible with both websites mentioned above.

Attachments (0)

Change History (8)

comment:1 Changed on 09/06/2017 at 09:47:49 PM by juliandoucette

  • Description modified (diff)

comment:2 Changed on 09/06/2017 at 09:50:39 PM by juliandoucette

  • Milestone adblockplus.org 2.0.0 deleted

comment:3 Changed on 09/18/2017 at 01:19:56 PM by juliandoucette

  • Blocking 5634 removed
  • Priority changed from P2 to P3

comment:4 Changed on 10/24/2017 at 09:16:54 AM by ire

  • Owner set to ire

comment:5 Changed on 10/25/2017 at 10:03:42 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 11/02/2017 at 09:28:27 AM by ire

  • Review URL(s) modified (diff)

comment:7 Changed on 01/09/2018 at 08:00:59 AM by abpbot

A commit referencing this issue has landed:
Issue 5635 - Implement website-default navbar component

comment:8 Changed on 01/09/2018 at 08:01:41 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.