Opened on 09/11/2017 at 01:44:47 AM
Closed on 09/11/2017 at 04:25:08 PM
Last modified on 09/13/2017 at 12:08:20 AM
#5649 closed defect (fixed)
AppxMainfest.xml includes truncated version umber
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.0-for-Firefox |
Module: | Automation | Keywords: | |
Cc: | oleksandr, tlucas | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by sebastian)
How to reproduce
Run ./build.py -t edge -b 1234 (or inspect the devbuild from the Windows Store)
Observed behaviour
The version attribute in the Identity node in AppxMainfest.xml is set to 0.9.11.0, while the version number given in the build's filename and manifest.json file includes the build number as 4th component.
The incomplete version number from AppxMainfest.xml also shows up in the Windows Store developer dashboard.
That is because the version given in the metadata file is overriding the final version number already given in params, when AppxMainfest.xml is generated.
Expected behaviour
AppxMainfest.xml and manifest.json should include the same version number, with the build number (provided by the -b option) in the 4th component.
Attachments (0)
Change History (7)
comment:1 Changed on 09/11/2017 at 01:46:19 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/11/2017 at 04:23:54 PM by abpbot
comment:4 Changed on 09/11/2017 at 04:25:08 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/11/2017 at 04:28:25 PM by abpbot
A commit referencing this issue has landed:
Issue 5649 - Update buildtools dependency fixing version in AppxMainfest.xml
comment:6 Changed on 09/11/2017 at 04:28:44 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
A commit referencing this issue has landed:
Issue 5649 - Include full version number in AppxManifest.xml