Opened on 09/11/2017 at 04:29:06 PM
Closed on 10/20/2017 at 09:41:26 AM
#5655 closed change (fixed)
Create a rules file for Swift Lint
| Reported by: | CraftyDeano | Assignee: | CraftyDeano |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | lint |
| Cc: | ashephard, dzhang | Blocked By: | |
| Blocking: | Platform: | iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by CraftyDeano)
Background
We will use Swift Lint to lint our swift files and ensure coding standards, however we first need to agree on a set of rules & configure a rules file inside the project.
What to change
- Agree on rules that should be applied
- Create & configure a configuration file for Swift Lint within the project.
Attachments (0)
Change History (5)
comment:1 Changed on 09/11/2017 at 04:31:46 PM by CraftyDeano
comment:3 Changed on 09/11/2017 at 11:54:19 PM by dzhang
I’ve drafted my answers for the swiftlint rules but I'll review them again later. I have some ideas for custom rules that I’d like to try that I'll add here.
comment:4 Changed on 09/28/2017 at 11:25:11 PM by CraftyDeano
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 10/20/2017 at 09:41:26 AM by CraftyDeano
- Resolution set to fixed
- Status changed from reviewing to closed
Landed
Note: See
TracTickets for help on using
tickets.
Created a spreadsheet of the current rules in Swift Lint and invited Andy & Daniel to submit their preferences on what rules should be enabled/disabled. Once complete, we will discuss outcomes.