Opened on 09/12/2017 at 09:28:24 PM
Closed on 09/25/2017 at 01:05:23 PM
#5667 closed change (fixed)
Add missing action extension icons & clean up file names
| Reported by: | dzhang | Assignee: | ashephard |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-for-iOS-next |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | |
| Cc: | mario, tiago, ashephard, CraftyDeano, martin | Blocked By: | #3184 |
| Blocking: | Platform: | iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by dzhang)
Background
The icon set for the Safari action extension requires a similiar treatment of adding missing icons and setting unique names as #5595.
The Xcode app icon template is a bit confusing and misleading. It has slots for every possible icon and it's easy to think they should all be filled in.
For extensions, I've gained a new understanding after doing more research into what icons are actually used.
I believe the following list is correct for the extension and we shouldn't add additional icons as they will consume storage.
abp-app-ext-icon-60-iphone@2x.png abp-app-ext-icon-60-iphone@3x.png abp-app-ext-icon-76-iphone@2x.png abp-app-ext-icon-83,5-ipad@2x.png
The other icons are used for spotlight, notifications, settings and the app store. None of those apply to the action extension.
The action extension icon is meant to be a transparent, monochrome version of the app icon according to Apple's App Extension guide.
Therefore, I recommend we reduce the included assets for the action extension to include only the app icons for iPhone, iPad and iPad Pro.
What to change
Add required icons while removing those that are not required. Give the icons unique names.
Please make names consistent with #5595.
Attachments (1)
Change History (10)
comment:1 Changed on 09/12/2017 at 09:29:57 PM by dzhang
- Summary changed from Add missing action extension icons to & clean up file names to Add missing action extension icons & clean up file names
Changed on 09/13/2017 at 09:25:17 AM by martin
comment:2 Changed on 09/13/2017 at 02:50:39 PM by ashephard
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/13/2017 at 02:52:03 PM by ashephard
- Owner set to ashephard
comment:7 Changed on 09/20/2017 at 02:27:11 AM by dzhang
- Type changed from defect to change
comment:8 Changed on 09/20/2017 at 10:54:44 AM by ashephard
Updated the codereview with the necessary changes.
comment:9 Changed on 09/25/2017 at 01:05:23 PM by ashephard
- Resolution set to fixed
- Status changed from reviewing to closed
Updated the ticket with the new icon along with all its sizes. Let me know if anything needs fixing.