#5677 (Update punycode.js) – Adblock Plus Issue Tracker

Update punycode.js

Reported by:

Assignee:

Priority:

Milestone:

Module:

Libadblockplus

Keywords:

Cc:

fhd, hfiguiere

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Unknown

Verified working:

Review URL(s):

It has been already done in adblockpluschrome, #4350, and it would be useful to do it in libadblockplus as well.

For the sake of simplicity copy punycode.js from adblockpluschrome repository
add support of module in convert_js.py
put punycode.js at the beginning of library_files list in libadblockplus.gyp because now it supports require mechanism.
change how it's used in lib/basedomain.js
add tests verifying that the new version still works
whatever else is required

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === It has been already done in ''adblockpluschrome'', #4350, and it would be useful to do it in ''libadblockplus'' as well. === What to change === - For the sake of simplicity copy `punycode.js` from ''adblockpluschrome'' repository - add support of `module` in `convert_js.py` - put `punycode.js` at the beginning of `library_files` list in `libadblockplus.gyp` because now it supports `require` mechanism. - change how it's used in `lib/basedomain.js` - add tests verifying that the new version still works - whatever else is required
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):

Action

leave as new .

resolve as The resolution will be set. Next status will be 'closed'.

reassign to The owner will be changed from (none).

codereview Next status will be 'reviewing'.

Context Navigation