Remove custom spacing units in help.eyeo.com

[ire]

Background

We currently have the following custom spacing units in the help.eyeo.com SCSS variables:

$xl: 60px;
$lg: 30px;
$md: 15px;
$sm: 10px;
$xs: 5px;

What to change

We have spacing units in website-defaults already, so find a way to use them instead.

[ire]

@juliandoucette: The current website-default spacing variables are much more limited:

$large-space: 4em !default;
$medium-space: 2em !default;
$small-space: 1em !default;

Plus, using ems is not always what we want. Should we add more nuance to the website-defaults spacing variables (and add more static spacers as well?)

[ire]

Marking this P5 until we decide on this.

[juliandoucette]

Can you provide a few examples of where static values are appropriate on help.eyeo.com?

[ire]

Replying to juliandoucette:

Can you provide a few examples of where static values are appropriate on help.eyeo.com?

I can't remember what I was referring to anymore :/

I'll go ahead and start on this and if I run into any blockers I'll bring it up during review

[abpbot]

A commit referencing this issue has landed:
​Issue 5765 - Remove custom spacing units in help.eyeo.com