Opened on 09/25/2017 at 07:14:09 AM

Closed on 12/11/2017 at 04:39:19 PM

#5765 closed change (fixed)

Remove custom spacing units in

Reported by: ire Assignee: ire
Priority: P5 Milestone: 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



We currently have the following custom spacing units in the SCSS variables:

$xl: 60px;
$lg: 30px;
$md: 15px;
$sm: 10px;
$xs: 5px;

What to change

We have spacing units in website-defaults already, so find a way to use them instead.

Attachments (0)

Change History (7)

comment:1 Changed on 09/25/2017 at 07:15:52 AM by ire

@juliandoucette: The current website-default spacing variables are much more limited:

$large-space: 4em !default;
$medium-space: 2em !default;
$small-space: 1em !default;

Plus, using ems is not always what we want. Should we add more nuance to the website-defaults spacing variables (and add more static spacers as well?)

comment:2 Changed on 11/15/2017 at 09:37:58 AM by ire

  • Priority changed from Unknown to P5

Marking this P5 until we decide on this.

comment:3 follow-up: Changed on 12/05/2017 at 04:09:10 PM by juliandoucette

Can you provide a few examples of where static values are appropriate on

comment:4 in reply to: ↑ 3 Changed on 12/08/2017 at 09:11:49 AM by ire

  • Owner set to ire
  • Ready set

Replying to juliandoucette:

Can you provide a few examples of where static values are appropriate on

I can't remember what I was referring to anymore :/

I'll go ahead and start on this and if I run into any blockers I'll bring it up during review

comment:5 Changed on 12/08/2017 at 09:57:03 AM by ire

  • Milestone set to 1.0.0
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 12/11/2017 at 04:38:20 PM by abpbot

A commit referencing this issue has landed:
Issue 5765 - Remove custom spacing units in

comment:7 Changed on 12/11/2017 at 04:39:19 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Note: See TracTickets for help on using tickets.