Opened on 09/29/2017 at 10:48:07 AM
Closed on 10/04/2017 at 08:55:35 AM
Last modified on 12/22/2017 at 12:31:30 PM
#5810 closed change (fixed)
Use "specialization" as Subscription display title
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | vickyyu | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We provide settings UI in libadblockplus-android to manage subscriptions. In filters dialog a list of subscriptions is shown (see attachment #1). At this time subscription "title" property from https://github.com/adblockplus/adblockpluscore/blob/master/chrome/content/ui/subscriptions.xml is being used and it's not human-friendly actually. According to mockups for our partners it should look like "German", "Russian", etc. We need to adjust it.
What to change
Use "specialization" property as Subscription display title
Attachments (2)
Change History (7)
Changed on 09/29/2017 at 10:49:07 AM by asmirnov
Changed on 09/29/2017 at 11:15:32 AM by asmirnov
With "specialization" as display title
comment:1 Changed on 09/29/2017 at 11:20:55 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/02/2017 at 10:49:59 AM by vickyyu
- Cc vickyyu added
comment:3 Changed on 10/04/2017 at 08:54:45 AM by abpbot
A commit referencing this issue has landed:
Issue 5810 - Use "specialization" as Subscription display title
comment:4 Changed on 10/04/2017 at 08:55:35 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/22/2017 at 12:31:30 PM by abpbot
A commit referencing this issue has landed:
Issue 5810 - Use "specialization" as Subscription display title
current UI in libadblockplus-android