Opened on 10/02/2017 at 10:53:08 PM

Closed on 10/14/2017 at 03:05:44 AM

#5820 closed change (fixed)

Clear warning for ARC semantic issue in AdblockPlus+Parsing.m

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: mario, tiago, ashephard, CraftyDeano Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29562682/

Description

Background

The following build warning appears in Xcode 9 after updating build settings as recommended. See #5818.

AdblockPlusSafariExtension/AdblockPlus+Parsing.m:249:12: Block captures an autoreleasing out-parameter, which may result in use-after-free bugs

What to change

Clear the warning.

Attachments (0)

Change History (2)

comment:1 Changed on 10/02/2017 at 11:34:41 PM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/14/2017 at 03:05:44 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.