Opened on 10/18/2017 at 01:25:58 PM

Closed on 01/08/2018 at 05:28:54 PM

Last modified on 03/28/2018 at 08:56:24 AM

#5873 closed change (fixed)

Show information about bundled filter list in the Language Dialog

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: options-page
Cc: wspee, jeen, greiner, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29655630/

Description (last modified by saroyanm)

Background

We currently are only showing the description in the Dialog, though ideally we would like to communicate to the user about bundled Easylist for the language that have one.

What to change

  • (Ideally) add "+ English" to the bundled filter list.
  • Add full filter list title in the grey brackets as specified

Hints for testers

This implementation affects how the data in lists and tables are being displayed in:

  • General tab
    • PRIVACY & SECURITY section options lists
    • LANGUAGE section (Including "Change" dialog and "Add language dialog") list
  • Whitelisted websites Tab
    • list of whitelisted website websites
  • Advanced tab
    • CUSTOMIZE ON-PAGE ACTIONS section options lists
    • FILTER LISTS Table FILTER LISTS column

Attachments (0)

Change History (8)

comment:1 Changed on 10/24/2017 at 06:20:34 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 01/02/2018 at 12:24:49 PM by saroyanm

  • Description modified (diff)

comment:3 Changed on 01/03/2018 at 08:54:40 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/08/2018 at 05:27:32 PM by abpbot

A commit referencing this issue has landed:
Issue 5873 - Show original subscription title in languages table

comment:5 Changed on 01/08/2018 at 05:28:54 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 01/08/2018 at 05:38:53 PM by saroyanm

  • Cc Ross added
  • Description modified (diff)

Updated hints for testers as this might go to the next release.

comment:7 Changed on 01/08/2018 at 05:39:55 PM by saroyanm

  • Description modified (diff)

comment:8 Changed on 03/28/2018 at 08:56:24 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.