Opened on 10/19/2017 at 11:54:04 AM
Closed on 09/10/2019 at 03:21:16 PM
#5879 closed defect (duplicate)
Acceptable Ads radio button selection jumps around
| Reported by: | Ross | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | User-Interface | Keywords: | options-page |
| Cc: | sebastian, greiner, saroyanm, wspee | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
ABP 2.99.0.1889beta
Firefox 57 / Windows 10
How to reproduce
- Open ABP Settings.
- Leave the settings open for awhile?
- Select various AA options in the General tab.
Observed behaviour
The radio option selection flickers between even non-selected options before settling on the option the user selected. This doesn't occur all the time, but enough to be noticable. See attached video.
Expected behaviour
To behave like normal radio buttons (de-select one, select another).
Attachments (1)
Change History (9)
Changed on 10/19/2017 at 12:02:54 PM by Ross
comment:1 Changed on 10/19/2017 at 12:03:11 PM by Ross
- Summary changed from Acceptable Ad radio button selection jumps around to Acceptable Ads radio button selection jumps around
comment:2 Changed on 10/20/2017 at 04:23:48 AM by sebastian
- Cc greiner saroyanm wspee added
comment:3 Changed on 10/20/2017 at 11:32:02 AM by saroyanm
comment:4 Changed on 10/20/2017 at 11:33:07 AM by saroyanm
- Priority changed from Unknown to P4
- Ready set
comment:5 Changed on 10/20/2017 at 12:26:49 PM by saroyanm
- Keywords options-page added
comment:6 Changed on 10/27/2017 at 01:46:27 PM by Ross
Okay. That makes perfect sense. Another solution could be to cover that container with an overlay element with a spinner (or something) until it's "done".
comment:7 Changed on 09/09/2019 at 03:38:25 PM by greiner
@saroyanm Has there been any progress on this? It'd be great if we could create a GitLab issue for this, in case it still occurs, so that we can close this ticket.
comment:8 Changed on 09/10/2019 at 03:21:16 PM by saroyanm
- Resolution set to duplicate
- Status changed from new to closed
Can reproduce this one, but created this -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/581
Those are probably related. Resolving this as a duplicate.
Short terms: Acceptable Ads(AA), Privacy Friendly Acceptable Ads(PFAA)
Yes, this one is a little bit tricky to handle, we do update the selection to reflect the current state:
Click on each radio button makes flickering effect because we have several async actions assigned to the selection. For example click on Allow only nonintrusive ads that are privacy-friendly removes Allow some nonintrusive ads and add Allow only nonintrusive ads that are privacy-friendly, meanwhile it may jumps to Block All Ads, because we can have situation when there is no AA and PFAA until both actions succeed.
I agree that the flickering is annoying. We will launch new version soon, where we will replace Radio buttons with checkboxes. There we might have similar issue.
Anyway I'll try to think about how to make this less annoying, but I can think about solution right now that will eliminate flickering completely, though maybe with checkboxes it might be easier to handle.