Opened on 10/20/2017 at 08:30:34 AM

Closed on 10/24/2017 at 02:10:41 PM

#5888 closed change (fixed)

Issue reporter is using the wrong font

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee, nicole Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29587605/

Description

Background

While the issue reporter took most styles over from the new options page, it uses a different font setting.

What to change

Use the same custom font as the new options page.

Integration notes

The font files skin/fonts/SourceSansPro-*.woff from the adblockplusui repository have to be added to the build.

Attachments (0)

Change History (6)

comment:1 Changed on 10/20/2017 at 08:30:51 AM by trev

  • Blocking 5883 added
  • Cc greiner wspee nicole added

comment:2 Changed on 10/24/2017 at 11:02:34 AM by trev

  • Owner set to trev

comment:3 Changed on 10/24/2017 at 11:05:44 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/24/2017 at 11:12:35 AM by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed on 10/24/2017 at 02:07:28 PM by abpbot

A commit referencing this issue has landed:
Issue 5888 - Made issue reporter use the right font

comment:6 Changed on 10/24/2017 at 02:10:41 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.