Opened on 10/20/2017 at 10:49:43 AM
Closed on 10/20/2017 at 12:07:26 PM
Last modified on 10/20/2017 at 12:43:56 PM
#5895 closed change (fixed)
Let npm not try to resolve optional dependencies
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | kzar, sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
After #5535 npm install causes warnings while trying to resolve optional dependencies, e.g.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.2 (node_modules/fsevents):
This again causes our servers running cron to dispatch pointless emails.
What to change
Change ensure_dependencies.py to run npm install with an additional paramter --no-optional, preventing it from trying to resolve not explicitly needed dependencies.
Attachments (0)
Change History (5)
comment:1 Changed on 10/20/2017 at 10:58:50 AM by kzar
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 10/20/2017 at 10:59:31 AM by tlucas
- Owner set to tlucas
comment:3 Changed on 10/20/2017 at 12:06:48 PM by abpbot
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5895 - Don't resolve optional npm dependencies