Opened on 06/02/2014 at 06:09:22 AM
Closed on 06/02/2014 at 10:55:07 AM
#594 closed defect (fixed)
Typo in preferences window tooltip for the slow filters column
| Reported by: | Gingerbread Man | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-2.6.2-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, philll | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Adblock Plus 2.6.1.3824 • Nightly 32.0a1 (2014-06-01)
How to reproduce
- Open the preferences window.
- If filters aren't displayed on the right, press Ctrl+R to show them.
- Place the mouse cursor over the ! for the slow filters column.
Observed behavior
The tooltip says, "Slo&w filters".
Expected behaviour
The tooltip should say, "Slow filters".
Forum thread
Attachments (1)
Change History (5)
Changed on 06/02/2014 at 06:09:38 AM by Gingerbread Man
comment:1 Changed on 06/02/2014 at 07:19:28 AM by philll
- Cc trev philll added
@trev: this file contains a lot of translations with ampersands where I wouldn't expect them, being created by you. I guess it was by coincidence of some strange input method used? If yes, please let me know, whether I should fix it or whether you want to do that.
comment:2 Changed on 06/02/2014 at 08:56:21 AM by trev
The ampersands indicate which letter should be the access key (see https://developer.mozilla.org/en/docs/XUL_Accesskey_FAQ_and_Policies for more information on access keys). The issue here is that we use the same string both for the menu item and tooltip.
comment:3 Changed on 06/02/2014 at 09:09:56 AM by trev
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 06/02/2014 at 10:55:07 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
slow_filters_tooltip.png