Opened on 10/27/2017 at 01:05:03 PM

Closed on 11/13/2017 at 11:35:50 AM

#5954 closed defect (fixed)

Read-only properties cannot be assigned in strict mode in Edge

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29590603/

Description

Environment

Windows 10 Fall Creators Update.
adblockpluschrome 3db52fa9def8

How to reproduce

  1. Open options page
  2. Hit F12
  3. Refresh the options page

Observed behaviour

There is an error message SCRIPT5045: Assignment to read-only properties is not allowed in strict mode. I guess some APIs cannot be overridden in Strict mode . Which means we cannot override async functions.

Expected behaviour

Async functions should be overridden.

Attachments (0)

Change History (3)

comment:1 Changed on 10/27/2017 at 01:16:12 PM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/13/2017 at 11:31:33 AM by abpbot

A commit referencing this issue has landed:
​Issue 5954 - Read-only properties cannot be assigned in strict mode in Edge

comment:3 Changed on 11/13/2017 at 11:35:50 AM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.