Opened on 11/01/2017 at 11:25:49 AM
Closed on 11/23/2017 at 12:28:45 PM
Last modified on 11/29/2017 at 01:26:15 PM
#5965 closed defect (fixed)
ABP subscribe links do not function in Firefox
| Reported by: | Ross | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | trev, sebastian, mjethani, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 2.99.0.1902beta
Firefox 57 / Windows 10
How to reproduce
- Select a subcribe link from https://adblockplus.org/subscriptions
Observed behaviour
The ABP options page is opened, but no confirmation dialog is displayed and no list is added.
Expected behaviour
The options page to open, a confirmation dialog to appear and the list to be subscribed to on confirmation.
Attachments (1)
Change History (20)
comment:1 Changed on 11/01/2017 at 12:00:50 PM by Ross
comment:2 Changed on 11/01/2017 at 09:59:06 PM by sebastian
- Cc manish added
- Component changed from Unknown to Platform
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/03/2017 at 03:07:53 PM by mjethani
- Cc mjethani added; manish removed
comment:4 Changed on 11/04/2017 at 09:12:25 AM by mjethani
I tried to reproduce this issue with Firefox 57.0b12 on macOS with 2.99.0.1902beta, 2.99.0.1907beta, and master, and in all three cases it worked fine.
Ross, could you try again with the latest build and, if possible, on both macOS and Windows?
comment:5 Changed on 11/04/2017 at 09:22:05 AM by trev
Ross mentioned already that this doesn't seem to be reproducible reliably. Also, I have a strong suspicion that this is a Windows-only issue like #5817. At least I wasn't able to reproduce on Linux.
comment:6 Changed on 11/08/2017 at 01:26:59 PM by mapx
windows tests FF 57, ABP 3.0.0.1911beta:
- click subscribe a list (on this page) https://adblockplus.org/subscriptions
- options page is opened, no confirmation dialogue
- stay on options page and click again the subscribing link ==> now the confirmation dialogue is opened.
- if I click again subscribing for the same list => the addon does not warning the list is already subscribed.
However, I get no error in console.
comment:7 Changed on 11/08/2017 at 01:27:27 PM by mapx
- Cc mapx added
comment:8 Changed on 11/09/2017 at 02:09:25 PM by Ross
Reproduced steps mapx has added. If the options page is not already open, the dialog does not appear. If the options page is already open it does. There is also no warning about adding a duplicate subscriptions.
I've also noticed that the subscription is added before the confirmation dialog is answered, and if the user chooses "no" (via the top right X) the subscription is still present.
ABP 3.0.1
Firefox 57 / Windows 10
comment:9 Changed on 11/09/2017 at 02:11:56 PM by mapx
- Cc greiner added
comment:10 Changed on 11/09/2017 at 02:24:37 PM by trev
- Cc greiner removed
While I am still unable to reproduce this issue using these steps, I'm fairly certain that it is the same issue as in #5817 - the message sent to the options page arrives before the page is ready. So it's not a UI issue but rather still Platform.
comment:11 Changed on 11/09/2017 at 02:31:46 PM by trev
Actually - no, the code seems to wait for the page to be ready already.
comment:12 Changed on 11/10/2017 at 05:00:17 PM by kzar
I've not been able to reproduce this on Debian Buster with Firefox 57.0b9, I'll have a try with Windows 10 when I get a chance.
comment:13 Changed on 11/10/2017 at 05:06:40 PM by kzar
I can reproduce this with Alockplus 3.0.1 on Firefox 57.0 and Windows 10.
comment:14 Changed on 11/10/2017 at 05:09:26 PM by kzar
- Owner set to kzar
Going to stop soon but I'll investigate further next week.
comment:15 Changed on 11/11/2017 at 03:17:14 PM by kzar
The message responder for "subscriptions.add" calls showOptions, but the callback for showOptions is not being made. It seems that's because findOptionsTab in lib/options.js is returning undefined, despite searching for the correct URL for the options page.
It seems this is because the tab Object that browser.tabs.query is returning for the options page has a url of "about:blank" (but a title containing the URL we were expecting). I'll attached a screenshot to show what I mean.
Changed on 11/11/2017 at 03:17:32 PM by kzar
comment:16 Changed on 11/11/2017 at 04:38:04 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:17 Changed on 11/23/2017 at 12:04:58 PM by abpbot
A commit referencing this issue has landed:
Issue 5965 - Handle edge case when searching for options page tab
comment:18 Changed on 11/23/2017 at 12:28:45 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:19 Changed on 11/29/2017 at 01:24:17 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed in Firefox 51-57. I've added a note to #5971 for Firefox 50.
Still works as expected in Chrome/Opera.
ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Firefox 57 / Galaxy J5 / Android 6.0.1
Chrome 49 / 62 / Windows 7
Opera 36 / 48 / Windows 7
This worked in a previous build (1889 IIRC)