Opened on 11/03/2017 at 01:20:01 PM
Closed on 11/03/2017 at 02:43:11 PM
#5986 closed change (fixed)
Update adblockpluscore dependency to revision 000df4267bc8
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.0-for-Firefox |
Module: | Platform | Keywords: | |
Cc: | kzar, sebastian | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
We need to import the fix for #5956 so that element hiding emulation works reliably on Firefox. This will also import https://hg.adblockplus.org/adblockpluscore/rev/dbfc37143497 - a change in the way { and } are escaped in element hiding emulation selectors, something that should have any visible effects.
What to change
Updating dependency should be sufficient.
Attachments (0)
Change History (4)
comment:1 Changed on 11/03/2017 at 01:22:30 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/03/2017 at 01:27:49 PM by kzar
- Cc kzar sebastian added
- Priority changed from Unknown to P2
comment:3 Changed on 11/03/2017 at 02:42:21 PM by abpbot
A commit referencing this issue has landed:
Issue 5986 - Update adblockpluscore dependency to revision 000df4267bc8
comment:4 Changed on 11/03/2017 at 02:43:11 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Mind adding some hints for testers?