Opened on 11/04/2017 at 12:36:56 AM

Closed on 11/08/2017 at 01:27:53 AM

#5992 closed change (fixed)

Improve writing of function website(fromURL:)

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, CraftyDeano Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29596746/

Description

Background

During post review analysis, it was found that the logic in website(fromURL:) in class ABPManager could be expressed more clearly by rolling the url check into the string processing and having all error cases handled by the end of the function.

What to change

Update website(fromURL:) with its improved form.

Attachments (0)

Change History (2)

comment:1 Changed on 11/04/2017 at 12:47:24 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/08/2017 at 01:27:53 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.