Opened on 11/06/2017 at 03:06:22 PM
Closed on 11/09/2017 at 09:32:57 AM
Last modified on 10/08/2019 at 05:58:31 PM
#5998 closed change (duplicate)
Update "how to disable AA on Firefox" on About - Adblockplus.org
| Reported by: | Kai | Assignee: | ire |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | content, goodfirstbug |
| Cc: | juliandoucette, wspee, jnink, jeen, lisabielik | Blocked By: | #6007 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by ire)
Background
After the update of ABP to 3.0 in Firefox the current text on how to disable AA here: https://adblockplus.org/en/acceptable-ads#optout
is misleading and needs to be corrected.
What to change
Change the first two bulletpoints from
**Chrome, Maxthon, Opera, Safari** - Click the Adblock Plus icon and select **Options**. Uncheck **Allow some nonintrusive advertising**. **Firefox** - Click the Adblock Plus icon and select **Filter preferences**. Uncheck **Allow some nonintrusive advertising**.
to
**Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari** - Click the Adblock Plus icon and select **Options**. Uncheck **Allow some nonintrusive advertising**. **Firefox (ABP versions 1 and 2)** - Click the Adblock Plus icon and select **Filter preferences**. Uncheck **Allow some nonintrusive advertising**.
Attachments (0)
Change History (22)
comment:1 Changed on 11/06/2017 at 03:13:00 PM by ire
comment:2 Changed on 11/06/2017 at 03:14:33 PM by ire
- Cc jnink added; judith_n removed
comment:3 Changed on 11/06/2017 at 03:17:52 PM by ire
- Owner set to ire
- Ready set
comment:4 Changed on 11/06/2017 at 03:21:16 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 11/06/2017 at 03:22:14 PM by wspee
- Ready unset
comment:6 Changed on 11/06/2017 at 03:30:41 PM by Kai
I think we can live with that minor error for now. Users will get to the options page at least and then its obvious what they need to uncheck. I propose we update the text again after all translations of the UI texts are live and we can come up with a global 100 % accurate solution.
What do you think?
Kai
comment:7 Changed on 11/06/2017 at 03:37:41 PM by juliandoucette
- Cc jeen lisabielik added
- Description modified (diff)
- Keywords content goodfirstbug added
What do you think?
I agree. But this is a product decision. What do you think Jeen/Lisa?
comment:8 Changed on 11/06/2017 at 03:40:00 PM by wspee
- Description modified (diff)
I updated the description to be "technically" accurate (although the chrome version isn't released yet but now we cannot forget it).
comment:10 Changed on 11/06/2017 at 03:43:31 PM by wspee
- Description modified (diff)
Changed boldness
comment:11 Changed on 11/06/2017 at 04:13:41 PM by Kai
current wording fine for me.
@Jeen: Can you ACK this please?
comment:12 Changed on 11/06/2017 at 06:05:17 PM by jeen
LGTM
comment:13 Changed on 11/07/2017 at 09:52:23 AM by wspee
- Ready set
comment:14 follow-up: ↓ 16 Changed on 11/07/2017 at 04:27:04 PM by lisabielik
For consistency, it should read:
Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari
and
Firefox (ABP versions 1 and 2)
This is the final wording. Thanks!
comment:15 Changed on 11/07/2017 at 09:34:06 PM by ire
- Description modified (diff)
comment:16 in reply to: ↑ 14 Changed on 11/07/2017 at 09:35:09 PM by ire
Replying to lisabielik:
For consistency, it should read:
Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari
and
Firefox (ABP versions 1 and 2)
This is the final wording. Thanks!
Thanks Lisa. Just to be extra clear, could you have a look at the updated ticket description and let me know if that is what you want?
comment:17 follow-up: ↓ 18 Changed on 11/08/2017 at 05:06:58 PM by lisabielik
Hi Ire:
Sorry for all of the confusion. Yes, everything LGTM.
Can we wait to push this until we revert this page back to its original state? I don't know if you've been following this discussion on #websites, but we have decided to revert this page because of translations. Essentially, we want to ensure that the small changes requested in this ticket make it into the next round of translations.
Please let me know if you have any questions. Thank you! :)
comment:18 in reply to: ↑ 17 Changed on 11/08/2017 at 05:18:00 PM by ire
- Blocked By 6007 added
- Ready unset
Replying to lisabielik:
Hi Ire:
Sorry for all of the confusion. Yes, everything LGTM.
Can we wait to push this until we revert this page back to its original state? I don't know if you've been following this discussion on #websites, but we have decided to revert this page because of translations. Essentially, we want to ensure that the small changes requested in this ticket make it into the next round of translations.
Please let me know if you have any questions. Thank you! :)
Thanks Lisa! Sure I will wait. Marking this as unready until #6007 is completed
comment:19 Changed on 11/09/2017 at 07:50:32 AM by ire
- Ready set
comment:20 Changed on 11/09/2017 at 09:32:57 AM by wspee
- Resolution set to duplicate
- Status changed from reviewing to closed
This change will be done together with other changes via #6012 instead.
comment:21 Changed on 03/10/2019 at 04:28:55 PM by tarkesh
spam
comment:22 Changed on 03/10/2019 at 05:49:22 PM by juliandoucette
Hello, tarkesh;
Cool question! But I'm afraid this is not an appropriate place to ask. Instead, please email support at adblockplus.org.
In ABP for Firefox 3.0.0 the checkbox is not labeled Uncheck Allow some nonintrusive advertising."