Opened on 11/10/2017 at 09:30:56 AM
Closed on 11/10/2017 at 10:09:31 AM
Last modified on 12/11/2017 at 09:42:05 AM
#6022 closed defect (fixed)
Update buildtools dependency to 014321e2dfa3
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | tlucas, sebastian, trev | Blocked By: | #5997, #6020 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
With the recent switch to webpack some files were being erroneously included in the builds. We've resolved those issues (#6020, #5997) in the buildtools and now need to update that dependency for the extension.
Included changes in buildtools
The list of changes imported by this is:
What to change
Update the buildtools dependency to:
| mercurial | git |
| 014321e2dfa3 | 6b014d0 |
One unrelated change (#5994) is included, but that shouldn't matter at all.
Hints for testers
- Check that sitekey based whitelisting still works.
Attachments (0)
Change History (5)
comment:2 Changed on 11/10/2017 at 09:47:35 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/10/2017 at 10:09:08 AM by abpbot
comment:4 Changed on 11/10/2017 at 10:09:31 AM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/11/2017 at 09:42:05 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Child tickets appear to be working correctly.
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6022 - Update buildtools dependency to revision 014321e2dfa3