Opened on 11/10/2017 at 06:42:50 PM

Closed on 02/19/2018 at 03:41:12 PM

#6027 closed change (fixed)

Redirect help.eyeo.com to help.eyeo.com/adblockplus

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Unknown Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29699557

Description

Background

When we launch the help center, we will only have information related to Adblock Plus. Because of this, we didn't create a general Help Center Homepage and the index page on the help.eyeo.com repository is blank.

What to change

Redirect help.eyeo.com to help.eyeo.com/adblockplus

Attachments (0)

Change History (11)

comment:1 Changed on 11/10/2017 at 06:43:11 PM by ire

I'm not sure what Module this ticket should belong to. @julian/@wspee help?

comment:2 follow-up: Changed on 11/20/2017 at 10:46:07 AM by wspee

I think there is no need to implement the redirect at the moment. The domain help.eyeo.com is new and it is up to us to introduce it. If we do so I would imagine that we link to the specific sub page (i.e. we add a link to help.eyeo.com/adblockplus to the extension and not help.eyeo.com). So I would like to wait and see before adding any redirects. What do you think?

comment:3 follow-up: Changed on 11/21/2017 at 03:18:22 PM by juliandoucette

What do you think?

If we do that then we need something to put on the homepage.

I'm not sure what Module this ticket should belong to. @julian/@wspee help?

Infrastructure. But the ops team uses eyeo hub now instead of trac; unfortunately.

comment:4 in reply to: ↑ 3 Changed on 11/22/2017 at 02:15:13 PM by wspee

Replying to juliandoucette:

If we do that then we need something to put on the homepage.

Doesn't the same logic also apply to putting something on the homepage? But I don't have a strong opinion, if you prefer to not have an empty startpage I won't object but then we could also go with redirect? I just thought that we don't need it for the initial version and that it will have changed anyways before it becomes relevant.

comment:5 in reply to: ↑ 2 Changed on 11/27/2017 at 08:51:29 AM by ire

Replying to wspee:

I think there is no need to implement the redirect at the moment. The domain help.eyeo.com is new and it is up to us to introduce it. If we do so I would imagine that we link to the specific sub page (i.e. we add a link to help.eyeo.com/adblockplus to the extension and not help.eyeo.com). So I would like to wait and see before adding any redirects. What do you think?

At the moment, the homepage is basically just a blank page, which I think we agree we would want to avoid users ever having to see. If we don't do a redirect, we won't be able to stop users from accessing the homepage even if we never link to it from anywhere. e.g. if a user goes to help.eyeo.com/adblockplus, they can look at the url and infer that there must be a help.eyeo.com available.

I personally think a redirect is the best way to go because a homepage with nothing but a link to the adblockplus help homepage isn't a great experience. When we add another product to the help center, then it'll make sense to have a proper homepage.

comment:6 Changed on 01/26/2018 at 08:55:58 AM by ire

@wspee Any more thoughts on this? If you agree, we can do it on the front end for now, which would be relatively quick and straightforward

comment:7 follow-up: Changed on 01/27/2018 at 05:06:18 PM by wspee

@ire I don't disagree with anything you said. I just believe that the help center will change significantly before it will be used by any users. Given that the redirect is just a small thing we can add anytime I would suggest to wait and see what will happen, but of course by the same logic could also be used to add it right away :). So if anybody feels strongly about it please go ahead and add it. For production a front end redirect is probably sub optimal because of search engines, though.

comment:8 in reply to: ↑ 7 Changed on 02/16/2018 at 03:08:55 PM by ire

  • Owner set to ire
  • Ready set

Replying to wspee:

@ire I don't disagree with anything you said. I just believe that the help center will change significantly before it will be used by any users. Given that the redirect is just a small thing we can add anytime I would suggest to wait and see what will happen, but of course by the same logic could also be used to add it right away :). So if anybody feels strongly about it please go ahead and add it. For production a front end redirect is probably sub optimal because of search engines, though.

Okay. Seeing as it seems that we will end up launching the help center as soon as possible and with only abp content, I will go ahed and start implementing this.

comment:9 Changed on 02/16/2018 at 03:20:40 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed on 02/19/2018 at 03:40:21 PM by abpbot

A commit referencing this issue has landed:
Issue 6027 - Redirect help.eyeo.com to help.eyeo.com/adblockplus

comment:11 Changed on 02/19/2018 at 03:41:12 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.