Opened on 11/13/2017 at 01:05:50 PM

Closed on 11/14/2017 at 01:42:29 PM

Last modified on 10/08/2019 at 06:03:27 PM

#6030 closed defect (fixed)

Exceptions thrown by content script if WebRTC is disabled in Firefox

Reported by:	MarkyMark	Assignee:	kzar
Priority:	P2	Milestone:	Adblock-Plus-3.0.2-for-Firefox
Module:	Platform	Keywords:
Cc:	trev, sebastian, mapx, kzar	Blocked By:
Blocking:		Platform:	Firefox
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://codereview.adblockplus.org/29607555/

Description (last modified by kzar)

Environment

OS: OS X 10.11.6
Firefox 56.0.2 64-Bit
ABP Version: 3.0.1
Filter Lists:

Adblock Warning Removal List
EasyList Germany+EasyList
EasyPrivacy
Fanboy's Social Blocking List

How to reproduce

Disable WebRTC (about:config and set media.peerconnection.enabled to false)
Open a website e.g. https://www.startpage.com/
open the web-console
The console is showing an exception "TypeError: RealRTCPeerConnection is undefined" that comes from an APB Function:

Observed behaviour

Exception in browser-console coming from Adblock Plus:

TypeError: RealRTCPeerConnection is undefined search:190:1
injected            https://www.startpage.com/do/search:190:1
<anonym>            https://www.startpage.com/do/search:1:11
<anonym>            inject.preload.js:402
__webpack_require__ bootstrap%20ce37bec0cc7a6c7f06cd:19
<anonym>            moz-extension://718b0eb7-e1fe-5549-be5d-08a92e61d826/include.preload.js:169:18
__webpack_require__ bootstrap%20ce37bec0cc7a6c7f06cd:19
<anonym>            bootstrap%20ce37bec0cc7a6c7f06cd:62
<anonym>            moz-extension://718b0eb7-e1fe-5549-be5d-08a92e61d826/include.preload.js:1:11
inject              resource://gre/modules/ExtensionContent.jsm:339:18
next                self-hosted:1183:9

Expected behaviour

No exception

Hints for testers

Ensure that WebRTC blocking still works as before.
Check that the above exception is no longer shown in the page console with Firefox when the media.peerconnection.enabled option is set to false.

Change History (10)

comment:1 Changed on 11/13/2017 at 02:59:47 PM by mapx

Cc trev sebastian mapx kzar added

comment:2 Changed on 11/14/2017 at 08:40:01 AM by MarkyMark

Step 3 is a little bit different: open web-console, not browser-console.

comment:3 Changed on 11/14/2017 at 08:52:23 AM by mapx

Description modified (diff)

comment:4 Changed on 11/14/2017 at 10:24:15 AM by kzar

Component changed from Unknown to Platform
Description modified (diff)
Owner set to kzar
Priority changed from Unknown to P2
Ready set
Summary changed from ABP does not check/work if WebRTC is disabled to Exceptions thrown by content script if WebRTC is disabled in Firefox

comment:5 Changed on 11/14/2017 at 10:37:00 AM by kzar

Description modified (diff)
Review URL(s) modified (diff)
Status changed from new to reviewing

comment:6 Changed on 11/14/2017 at 01:42:10 PM by abpbot

A commit referencing this issue has landed:
Issue 6030 - Ensure RTCPeerConnection exists before wrapping it

comment:7 Changed on 11/14/2017 at 01:42:29 PM by kzar

Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
Resolution set to fixed
Status changed from reviewing to closed

comment:8 Changed on 12/05/2017 at 01:09:04 PM by Ross

Tester changed from Unknown to Ross
Verified working set

Fixed. WebRTC blocking still appears to work as expected and the exception no longer appears in the web console.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7

comment:9 Changed on 09/16/2019 at 07:47:04 AM by moffu

spam

Last edited on 10/08/2019 at 06:03:27 PM by kzar

comment:10 Changed on 10/04/2019 at 06:02:39 AM by charlotte

spam

Last edited on 10/08/2019 at 06:03:25 PM by kzar

Context Navigation