Opened on 11/22/2017 at 11:03:01 AM

Closed on 12/05/2017 at 02:20:09 PM

#6073 closed change (fixed)

Update the 'Favicon' library to restrict API usage to only Extension-valid APIs

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: #4791 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29615614/

Description

Background

The Favicon library is used within the ABP for iOS project and in order to suppress a warning (and avoid any potential rejections from the App Review process), the library needs to restrict API usage to only Extension-valid APIs.

What to change

Within the Favicon project, change the Build Setting flag 'restrict API usage to only Extension-valid APIs' needs to be enabled.

Attachments (0)

Change History (3)

comment:1 Changed on 11/28/2017 at 10:54:17 AM by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/29/2017 at 10:38:39 AM by ashephard

  • Owner set to ashephard

comment:3 Changed on 12/05/2017 at 02:20:09 PM by ashephard

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
 
Note: See TracTickets for help on using tickets.