Opened on 11/22/2017 at 12:34:21 PM
Closed on 11/22/2017 at 01:24:54 PM
Last modified on 11/29/2017 at 12:47:57 PM
#6074 closed defect (fixed)
checkbox.svg is missing in the generated dev builds
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, greiner, wspee, sebastian | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Firefox v56
Adblock Plus (devbuild): V3.0.1.1931
How to reproduce
- Open the options page
Observed behaviour
The checkboxes on the General page are missing.
Expected behaviour
The checkboxes are displayed properly.
Notes
- This is a regression caused by 4258e278fe29.
Attachments (1)
Change History (11)
Changed on 11/22/2017 at 12:34:36 PM by saroyanm
comment:1 Changed on 11/22/2017 at 12:35:10 PM by saroyanm
- Summary changed from Add checkbox.svg to the metadata.chrome to checkbox.svg is missing in the generated dev builds
comment:2 Changed on 11/22/2017 at 12:37:36 PM by saroyanm
- Cc greiner wspee added
comment:3 Changed on 11/22/2017 at 12:40:43 PM by kzar
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Platform changed from Unknown / Cross platform to Firefox
- Priority changed from Unknown to P1
- Ready set
comment:5 Changed on 11/22/2017 at 12:41:49 PM by saroyanm
- Owner set to saroyanm
comment:6 Changed on 11/22/2017 at 12:51:37 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 11/22/2017 at 01:23:54 PM by abpbot
A commit referencing this issue has landed:
Issue 6074 - Added checkbox.svg to the Firefox builds
comment:8 Changed on 11/22/2017 at 01:24:54 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 11/22/2017 at 01:25:38 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:10 Changed on 11/29/2017 at 12:47:57 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Checkbox is displayed as expected.
ABP 3.0.1.1939
Firefox 57 / 50 / Windows 7
Note: See
TracTickets for help on using
tickets.
I can provide patch for fixing this when this will get ready.
Forgot to include checkbox.svg in the mapping