Opened on 11/23/2017 at 03:16:38 PM
Closed on 08/29/2019 at 05:48:47 PM
#6083 closed change (rejected)
Change ABP behaviour for first-party blocked requests
| Reported by: | mapx | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar, sebastian, arthur, fanboy, SMed79, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mapx)
Background
There are a lot of cases when the owners chose a "wrong" name for a site which wont work anymore due to some filter in easylist.
for example:
http://adflow.pl/ which is broken by a filter like /adflow. (now fixed in easylist)
What to change
I propose all the first-party generic blocking filters to be ignored. This way all these cases would be fixed and the easylist authors could remove all those exceptions like /adflow.$domain=~adflow.io|~adflow.pl or at least not adding other exceptions in the future (sure, other adblockers should implement the same behaviour).
Attachments (0)
Change History (11)
comment:1 in reply to: ↑ description Changed on 11/23/2017 at 08:46:13 PM by SMed79
comment:2 follow-up: ↓ 3 Changed on 11/24/2017 at 09:34:07 AM by arthur
However, to avoid abusing this change (banner images for example) ABP could ignore only stylesheet (css files) and scripts / xhr (avoiding part of the anti-adb tricks too) requests.
Then still it would affect other resources from the domain.
comment:3 in reply to: ↑ 2 Changed on 11/24/2017 at 09:58:39 AM by mapx
Replying to arthur:
However, to avoid abusing this change (banner images for example) ABP could ignore only stylesheet (css files) and scripts / xhr (avoiding part of the anti-adb tricks too) requests.
Then still it would affect other resources from the domain.
Right, no exception.
comment:4 Changed on 11/25/2017 at 06:50:28 AM by fanboy
I don't see any issue with current implementation, plus it could be open to abuse.
comment:5 Changed on 11/25/2017 at 09:45:45 AM by SMed79
So, what is better?
- exclude the concerned website form the generic filter in EasyList.
e.g /ad4.$domain=~ad4.fr
or
- whitelist the whole website in the regional list.
e.g @@|http://ad4.fr^$~third-party
comment:6 Changed on 11/25/2017 at 09:52:14 AM by mapx
It's not about an issue, it's about a change ticket.
More, as I added in description, an entire antiadb category would be fixed.
comment:9 Changed on 11/27/2017 at 12:35:21 PM by mapx
- for other regional lists (like Liste FR), if you implement $badfilter (#5901) , the author could simply disable the "bad" filter
comment:10 Changed on 12/21/2017 at 11:26:28 AM by fhd
- Cc trev removed
comment:11 Changed on 08/29/2019 at 05:48:47 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
This way, the authors of the regional lists don't need whitelisting a whole site.
e.g. https://hg.adblockplus.org/listefr/rev/c63ab8c648f5#l1.30