Opened on 11/23/2017 at 04:01:20 PM

Closed on 11/23/2017 at 04:22:09 PM

Last modified on 12/05/2017 at 11:28:57 AM

#6084 closed defect (fixed)

Filtering requests in Adblock Plus developer tools pane by request URL is broken

Reported by: greiner Assignee: kzar
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29616579/

Description (last modified by kzar)

Environment

Ubuntu 16.04
Chrome 62
Adblock Plus 3.0.1

How to reproduce

  1. Go to ​https://www.greinr.com/
  2. Open DevTools and switch to "Adblock Plus" tab
  3. Reload page to populate blockable items list
  4. Press CTRL+F to show search input field
  5. Search for "woff"

Observed behaviour

List is emptied

Expected behaviour

List only shows items whose URL contains the string "woff"

Notes

  • This is a regression caused by the changes for #6035, I updated the class name for the request's URL to resource-link but forgot to update the corresponding classname in devtools-panel.js.

Attachments (0)

Change History (6)

comment:1 Changed on 11/23/2017 at 04:06:34 PM by kzar

  • Component changed from Platform to User-Interface
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/23/2017 at 04:08:47 PM by kzar

  • Platform changed from Unknown / Cross platform to Chrome
  • Summary changed from DevTools search broken to Filtering requests in Adblock Plus developer tools pane by request URL is broken

comment:3 Changed on 11/23/2017 at 04:15:54 PM by kzar

  • Description modified (diff)
  • Owner set to kzar

comment:4 Changed on 11/23/2017 at 04:21:29 PM by abpbot

A commit referencing this issue has landed:
​Issue 6084 - Use new classname for devtools request URL filtering

comment:5 Changed on 11/23/2017 at 04:22:09 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 12/05/2017 at 11:28:57 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Filtering requests appears to work as expected.

ABP 3.0.1.1939
Firefox N/A (doesn't seem to support filtering)
Chrome 52 / 62 / Windows 10
Opera 39 / 49 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.