Opened on 11/24/2017 at 02:14:22 PM
Closed on 10/10/2018 at 01:54:32 PM
#6094 closed change (rejected)
Find actual reason of missing favicon in FF WebExts
Reported by: | saroyanm | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | greiner, kzar | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
Background
In #5972 we have implemented a stopgap solution for missing Favicon in the Adblock Plus for Firefox options page, we would like to communicate that better in the code, or find better solution for that.
What to change
- Find actual reason of missing Favicon in Firefox WebExtension Bundled pages, create Bugzilla ticket (if applicable) and communicate stopgap solution (if applicable).
Note
Favicon is also missing in the FirstRun page.
Attachments (0)
Change History (4)
comment:1 Changed on 11/24/2017 at 02:17:50 PM by saroyanm
- Cc greiner kzar added
- Description modified (diff)
- Summary changed from Find actual missing favicon reason in FF WebExts to Find actual reason of missing favicon in FF WebExts
comment:2 Changed on 11/24/2017 at 02:58:13 PM by greiner
- Component changed from Unknown to User-Interface
At this point there's no indication that this requires changes to any Platform code so I set the component to UI.
comment:3 Changed on 10/10/2018 at 12:38:07 PM by greiner
Is this issue still relevant?
comment:4 Changed on 10/10/2018 at 01:54:32 PM by saroyanm
- Resolution set to rejected
- Status changed from new to closed
Thanks @greiner: Opened a GItlab issue for missing favicon in FRP -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/227 This can be closed now and I'll add a separate trac ticket for submitting the changes.
The description bit vague, but I think should be enough for the beginning.
Should this be part of User interface module, or platform ?