Opened on 11/30/2017 at 11:03:35 AM

Closed on 11/30/2017 at 12:03:40 PM

Last modified on 12/08/2017 at 02:53:26 PM

#6110 closed defect (fixed)

New options page does not display correctly in Chrome 49-51

Reported by:	Ross	Assignee:	kzar
Priority:	P2	Milestone:
Module:	User-Interface	Keywords:
Cc:	wspee, greiner, kzar, sebastian, saroyanm	Blocked By:
Blocking:		Platform:	Chrome
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://codereview.adblockplus.org/29625598/

Description

Environment

adblockplusui / 200:98dd77c2b086
Chrome 49 / 51 / Windows 7

Looks fine in Chrome 52+

How to reproduce

Clone/update adblockplusui repo.
Run the test_server.py script.
Navigate to the desktop-options page served.

Observed behaviour

None of the text is present, all of the UI is collapsed and several errors about symbol.iterator are displayed in the console.

Expected behaviour

The new options page to display correctly.

Change History (10)

Changed on 11/30/2017 at 11:07:12 AM by Ross

Attachment 6110-optionspage-oldchrome.jpg added

comment:1 Changed on 11/30/2017 at 11:11:13 AM by Ross

I'm not sure if these errors are just test data related when running the test_server or would affect the page when displayed inside the extension.

Errors are:

Uncaught TypeError: elements[Symbol.iterator] is not a functionpolyfill.js:84

Uncaught TypeError: anchors[Symbol.iterator] is not a function desktop-options.js:1395

Uncaught (in promise) TypeError: elements[Symbol.iterator] is not a function(…) desktop-options.js:499

Uncaught TypeError: listItem.querySelectorAll(...)[Symbol.iterator] is not a function desktop-options.js:154

comment:2 follow-up: ↓ 8 Changed on 11/30/2017 at 11:29:58 AM by saroyanm

Ross, are you using webmate to test older Chrome browsers, or Virtual Machines ?

I used to have always issues with getting older Chrome versions installation on my device, after Google stopped to provide portable versions.

Will appreciate if you can help me, so I can test myself and update the ticket accordingly.

comment:3 Changed on 11/30/2017 at 11:31:38 AM by kzar

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:4 Changed on 11/30/2017 at 11:34:58 AM by saroyanm

Priority changed from Unknown to P2
Ready set

Marking this ready as Dave started to work on it and already has provided link to the Chromium bug.

comment:5 Changed on 11/30/2017 at 11:38:02 AM by greiner

Owner set to kzar

comment:6 Changed on 11/30/2017 at 12:03:05 PM by abpbot

A commit referencing this issue has landed:
Issue 6110 - Add the iterator polyfills to the test page

comment:7 Changed on 11/30/2017 at 12:03:40 PM by kzar

Resolution set to fixed
Status changed from reviewing to closed

comment:8 in reply to: ↑ 2 Changed on 11/30/2017 at 12:46:11 PM by Ross

Replying to saroyanm:

Ross, are you using webmate to test older Chrome browsers, or Virtual Machines ?

I used to have always issues with getting older Chrome versions installation on my device, after Google stopped to provide portable versions.

Will appreciate if you can help me, so I can test myself and update the ticket accordingly.

I usually use the virtual machines that have most versions installed already. Philip should be able to hook you up with access to them.

comment:9 Changed on 12/08/2017 at 02:52:00 PM by Ross

Tester changed from Unknown to Ross
Verified working set

Fixed.

adblockplusui / 203:0e99fec067ea
Chrome 49 / 51 / Windows 7
Opera 39 / 40 / Windows 7

Last edited on 12/08/2017 at 02:53:26 PM by Ross

Context Navigation