Opened on 12/08/2017 at 01:27:44 PM

Closed on 12/08/2017 at 01:35:47 PM

Last modified on 12/11/2017 at 10:07:14 AM

#6178 closed defect (fixed)

Update adblockplusui dependency to revision 24f73c8f3eb8

Reported by: kzar Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: saroyanm, sebastian, trev, Ross Blocked By: #6173
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29633605/

Description

Background

With #6173 we've added more translations for the page title of the new options page. We'd like to include those and so need to update the adblockplusui dependency.

Included changes in adblockplusui

The list of changes imported by this is:


What to change

Update the adblockplusui dependency to:

mercurial git
24f73c8f3eb8 643f079

No other changes will be included.

Hints for testers

Test that the title of the options page looks correct for Firefox users in various languages.

Attachments (0)

Change History (4)

comment:1 Changed on 12/08/2017 at 01:34:32 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/08/2017 at 01:35:14 PM by abpbot

comment:3 Changed on 12/08/2017 at 01:35:47 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 12/11/2017 at 10:07:14 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Options page title is translated.

ABP 3.0.1.1943
Firefox 52 / 57 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.