Opened on 12/13/2017 at 01:03:15 AM
Closed on 12/18/2017 at 05:25:15 PM
#6194 closed change (fixed)
Kitt-Core: ABB does not build with TypeScript 2.6.x in Xcode 9.2
| Reported by: | dzhang | Assignee: | dzhang |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-iOS-2.1.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by dzhang)
Background
A build error occurs in Xcode 9.2 when using TypeScript 2.6.x as installed by 'npm install'.
Here is a log of the reported errors:
src/JavaScriptBridge/TypeScriptInterface/main_content_mainframe.ts(69,13): error TS6133: 'html' is declared but its value is never read.
src/JavaScriptBridge/TypeScriptInterface/main_content_subframe.ts(40,15): error TS6133: 'html' is declared but its value is never read.
The TypeScript code may be able to be updated to work with the new TypeScript version but I'm uncertain of the impact any changes will have on the browser. Therefore, the conservative option is to limit the TypeScript version until these errors can be further evaluated. There is also a chance that the use of this TypeScript will be deprecated in favor of alternative options.
What to change
Limit the TypeScript version to 2.5.x instead of going to 2.6.x
Attachments (0)
Change History (6)
comment:2 Changed on 12/13/2017 at 01:04:27 AM by dzhang
- Summary changed from ABB does not build with Typescript 2.6.x in Xcode 9.2 to Kitt-Core: ABB does not build with Typescript 2.6.x in Xcode 9.2
comment:4 Changed on 12/13/2017 at 05:03:52 PM by dzhang
- Status changed from new to reviewing
comment:5 Changed on 12/13/2017 at 05:04:58 PM by dzhang
- Description modified (diff)
- Summary changed from Kitt-Core: ABB does not build with Typescript 2.6.x in Xcode 9.2 to Kitt-Core: ABB does not build with TypeScript 2.6.x in Xcode 9.2
comment:6 Changed on 12/18/2017 at 05:25:15 PM by dzhang
- Resolution set to fixed
- Status changed from reviewing to closed
