Opened on 12/14/2017 at 12:49:02 PM
Closed on 12/14/2017 at 01:27:30 PM
Last modified on 03/20/2018 at 09:49:52 AM
#6199 closed defect (fixed)
Acceptable Ads link broken on mobile options page
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | goodfirstbug |
| Cc: | wspee, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Nexus 5X
Android 8.1.0
Firefox 57
Adblock Plus 3.0.2
How to reproduce
- Open options page
- Click on "Learn more" link next to "Allow some non-intrusive advertising"
Observed behaviour
Options page is empty
Expected behaviour
New tab opens with information about Acceptable Ads
Further information
The options page is running within an iFrame so any link is, by default, opened within that frame. We acknowledged this issue when we decided to go for this workaround and checked links in the desktop options page but didn't notice that there'd be link on the mobile options page which are also affected by this.
Attachments (0)
Change History (5)
comment:1 Changed on 12/14/2017 at 12:50:04 PM by greiner
- Cc wspee saroyanm added
- Owner set to greiner
comment:2 Changed on 12/14/2017 at 12:57:48 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/14/2017 at 01:27:06 PM by abpbot
comment:4 Changed on 12/14/2017 at 01:27:30 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 03/20/2018 at 09:49:52 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.0.2.1983
Firefox 57 / Xperia Z / Android 5.1.1
Firefox 58 / Galaxy J5 / Android 7.1.1
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6199 - Fixed: Open link on mobile options page in new tab