Opened on 12/26/2017 at 02:15:18 PM

Closed on 01/10/2018 at 07:18:17 PM

#6219 closed change (fixed)

Create flavors per ABI

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29649555/

Description

Background

We provide AARs that contains shared native libraries (libadblockplus-jni.so) for all available arch (armeabi-v7a and x86). An end-user app that uses our AARs can filter out some arch while building.
However it can be convenient to have Gradle flavors to build AAR with shared library for some specific arch only. It can help to monitor AAR size though the V8 version or build it while building as Chromium submodule.

What to change

Update 'build.gradle' files to add flavors/env variable support to build per-ARCH AARs.

Attachments (0)

Change History (4)

comment:1 Changed on 12/26/2017 at 02:17:32 PM by asmirnov

  • Summary changed from Create flavours for ABIs to Create flavors per ABI

comment:2 Changed on 12/26/2017 at 02:21:39 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/10/2018 at 07:17:22 PM by abpbot

Some commits referencing this issue have landed:

comment:4 Changed on 01/10/2018 at 07:18:17 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.