Opened on 01/09/2018 at 07:24:35 AM

Closed on 01/10/2018 at 07:42:10 AM

#6236 closed change (fixed)

Restore patch from #5393 in order to make it possible to use other versions of V8

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29660563/

Description

Background

When libadblockplus is used in other projects with already existing V8 one can stumble upon the problem described in #5393.

What to change

Restore the changes patching gyp which fixes the order of libs.

Attachments (0)

Change History (3)

comment:1 Changed on 01/09/2018 at 07:36:22 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/10/2018 at 07:41:45 AM by abpbot

A commit referencing this issue has landed:
​Issue 6236 - fix libraries order issue when linking of V8 mksnapshot for linux host

comment:3 Changed on 01/10/2018 at 07:42:10 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.