Opened on 01/12/2018 at 07:25:16 PM

Last modified on 01/15/2018 at 05:50:12 AM

#6248 new change

Check per-platform build

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By: #6263
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We made it working for Android, but as it's single project for all the platforms we need to make sure it does not hurt the other platforms. We should be able to checkout and compile it for other platforms without AdblockPlus dependencies and AdblockPlus source code used (like there is no ABP integration at all).

What to change

Check DEPS, GN configs and C++ files to have proper conditions like is_android, #if defined(OS_ANDROID)

Attachments (0)

Change History (2)

comment:1 Changed on 01/12/2018 at 07:25:34 PM by asmirnov

  • Component changed from Unknown to Adblock-Plus-for-Chromium
  • Platform changed from Unknown / Cross platform to Android

comment:2 Changed on 01/15/2018 at 05:50:12 AM by asmirnov

  • Blocked By 6263 added

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.