Opened on 01/12/2018 at 08:28:15 PM
Last modified on 10/08/2019 at 06:03:53 PM
#6259 new change
Find more suitable event for element hiding
Reported by: | asmirnov | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Adblock-Plus-for-Chromium | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Android | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
While implementing element hiding (https://gitlab.com/adblockplus/chromium/commit/04b8bb8ba55ce187a68f12b4e7280440281fbc78) i had to introduce new event NOTIFICATION_DID_FINISH_NAVIGATION.
However i believe we could find more suitable event when the DOM is created but not yet rendered to avoid flickering (in some cases i still can see that empty block is shown and then JS injected and empty block is hidden).
What to change
Find more suitable event for element hiding and use it
Attachments (0)
Change History (1)
comment:1 Changed on 06/15/2019 at 01:55:53 PM by pappyvicky
Last edited on 10/08/2019 at 06:03:53 PM
by kzar
Note: See
TracTickets for help on using
tickets.
spam