Opened on 01/18/2018 at 01:58:35 AM

Closed on 01/19/2018 at 06:37:55 AM

#6284 closed change (fixed)

Unwrap optionals safely in filter list operations

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29672570/

Description

Background

From #5551, there are a few instances of forced unwrapping where nil is not safely checked.

What to change

Rewrite instances of unsafe optional unwrapping to be safe.

Attachments (0)

Change History (2)

comment:1 Changed on 01/18/2018 at 02:15:21 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/19/2018 at 06:37:55 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.