Opened on 01/24/2018 at 12:32:01 PM

Closed on 01/26/2018 at 01:30:19 PM

#6307 closed change (fixed)

Introduce external engine created callback

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29678590/

Description

Background

Sometimes we have to do some AdblockEngine initialization, let's say configure subscriptions.
Like here we do read and apply settings:
​https://github.com/adblockplus/libadblockplus-android/blob/master/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java#L51

What to change

Add external callback when adblock engine is created.

Attachments (0)

Change History (3)

comment:1 Changed on 01/24/2018 at 12:47:39 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/26/2018 at 01:29:54 PM by abpbot

Some commits referencing this issue have landed:

comment:3 Changed on 01/26/2018 at 01:30:19 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.