Opened on 01/26/2018 at 01:18:28 PM
Closed on 05/11/2018 at 09:48:54 AM
#6320 closed change (fixed)
Add summary for adblock setting
| Reported by: | jwangenheim | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29684564/ |
||
Description (last modified by jwangenheim)
Background
The AdblockWebView sample app also contains a settings page. All settings on that page have a summary/description, except the adblock enable/disable setting.
What to change
For consistency and to make sure people know what that settings is about (as the name is not very descriptive) we should also add a summary for his setting. We also should translate the summary in all available languages.
C&T said we should use the following wording:
Allow ad blocking on websites in this app
I already created a hub ticket for translations:
http://hub.eyeo.com/issues/7442
Attachments (1)
Change History (9)
comment:2 Changed on 01/26/2018 at 03:25:00 PM by jwangenheim
- Owner set to jwangenheim
comment:4 Changed on 01/30/2018 at 08:11:46 AM by asmirnov
- Priority changed from Unknown to P3
- Review URL(s) modified (diff)
- Status changed from new to reviewing
Changed on 01/30/2018 at 08:18:26 AM by asmirnov
comment:7 Changed on 05/11/2018 at 09:47:34 AM by abpbot
A commit referencing this issue has landed:
Issue 6320 - Add summary for adblock setting
comment:8 Changed on 05/11/2018 at 09:48:54 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
scr after implementing